perf: optimize streaming SSR buffer management#15620
Closed
ascorbic wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: ac373ca The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes buffer management in
renderToAsyncIterablefor streaming SSR. This is a follow-up to #15605 which focused on the render loop itself — this PR targets the buffer/encoding layer.What changed
The
write()method inrenderToAsyncIterablenow accumulates string chunks into acurrentStringvariable during the write phase, only encoding toUint8Arraywhen a non-string chunk arrives or whennext()is called. This replaces the previous approach of pushing mixedstring | Uint8Arrayinto the buffer and then rescanning + merging innext().Before:
next()iterated the buffer to find consecutive strings, concatenated them, encoded them, then did a second pass to merge allUint8Arrays. This was O(N²) in the number of string chunks due to the rescan.After: Strings are concatenated during
write()(O(1) per call), andnext()sees a buffer of onlyUint8Arrayentries — just measure total length and copy. OneTextEncoder.encode()call per flush instead of one per string-group.Benchmark results (vs main)
.mdstreaminglarge-arraystreamingmany-componentsstreamingmany-expressionsstreaming.astrostreamingNon-streaming paths are unaffected (they don't use
renderToAsyncIterable).What was tested and discarded
Three other optimizations were benchmarked individually and in combination during development:
promiseWithResolverscreation in the render loop. Hurt streaming component throughput by ~9%.renderChild— caused regressions.Only the buffer optimization (this PR) showed consistent improvement across all streaming benchmarks.